Add option to adjust checkmk agent exec timeout to prevent crashes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
|
I just noticed that there is some overlap with #25. I can rebase my changes after the other PR is merged. |
|
Don't worry about rebasing, I've permission to edit the previous pull request. Thus, I can simply rebase #25 as we review them. For the pull request itself, LGTM. One more person will review it, then we'll test some changes in a live scenario, and finally include it in the next release (I'll post an update). |
CheckmkCI
pushed a commit
that referenced
this pull request
Apr 8, 2024
CMK-16676 Closes: #26 Change-Id: I697df13efc1d6b5279396d626b0c335c51928892
|
Hi, the release is now available https://github.com/Checkmk/checkmk_kube_agent/releases/tag/v1.6.0 Kind regards, Sol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment (Ubuntu 22.04)
systemctl list-unit-filessometimes takes just a little bit over 5 seconds to complete. A long execution time for listing the unit files seems to be a known issue with systemd and is documented here. This leads to crashes of thecheckmk-machine-sections-collectoras the call to the checkmk agent has a hard-coded timeout of 5 seconds.This PR adds the option to adjust the checkmk agent exec timeout via a command-line option.